Skip to content

Regenerate archive docs with banner and and drop-down selector. #16685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Regenerate archive docs with banner and and drop-down selector. #16685

wants to merge 4 commits into from

Conversation

@Ajay-singh1
Copy link
Member

Description

Reference PR:- #16529

When we regenerated the archive the link pointing to the latest documentation is broken as it appends the \latest path to the relative link which breaks the URL this PR will fix that broken link and point it to the latest documentation on the site.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ajay-singh1 Ajay-singh1 requested a review from a team as a code owner July 17, 2025 10:29
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2025
craigbox
craigbox reviewed Jul 21, 2025
View reviewed changes
@Ajay-singh1 Ajay-singh1 requested a review from craigbox July 29, 2025 07:32
@Ajay-singh1
Copy link
Member Author

@craigbox This will work but needs to be tested first.

@craigbox
Copy link
Contributor

I'll take a look tomorrow.

@Ajay-singh1
Copy link
Member Author

Thanks!

@Ajay-singh1
Copy link
Member Author

Ajay-singh1 commented Jul 30, 2025 •
edited
Loading

VID-20250730-WA0000.mp4

Works as expected.✅

@Ajay-singh1 Ajay-singh1 changed the title Fix: Broken link when regenerating archive v1.24 and v1.25 Regenerate archive docs with banner and and drop-down selector. Aug 1, 2025
@Ajay-singh1 Ajay-singh1 added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 1, 2025
@Ajay-singh1 Ajay-singh1 closed this by deleting the head repository Aug 2, 2025
@craigbox
Copy link
Contributor

craigbox commented Aug 4, 2025

@Ajay-singh1 Ajay-singh1 closed this by deleting the head repository 2 days ago

I think that might have been an error?

@Ajay-singh1
Copy link
Member Author

Ajay-singh1 commented Aug 4, 2025 •
edited
Loading

I`m really sorry for this actually I had only master branch on my fork I wanted every branch in the upstream to be included in my fork so I had deleted the upstream fork.

@Ajay-singh1 Ajay-singh1 mentioned this pull request Aug 4, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigbox craigbox Awaiting requested review from craigbox

Assignees

No one assigned

Labels

area/test and release do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. kind/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ajay-singh1 @craigbox @istio-testing @istio-policy-bot